DEV: commands: graphically tag deprecated commands #2235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
|
I think maybe a yellow badge with black text might be more readable? |
Collaborator
Author
|
Thanks for the feedback, @kaitlynmichael. I changed the color to black on Redis "mtn dew" yellow. I don't know if that's an improvement or not. Feel free to weigh in, @mich-elle-luna. |
Collaborator
|
Cool, thanks for doing this. The only thing I see is that the tooltip is long enough to be cut off by the side margin, so maybe it should be shortened somehow? |
Collaborator
Author
|
@mich-elle-luna I just pushed a fix for the clipping problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2224.
Type "brpoplpush" into the Search commands... field. Hover over the Deprecated badge to observe the tooltip. Then click into the page to see that the badge is also on the individual command page.
Here are the staging links:
https://redis.io/docs/staging/DOC-5810/commands/?name=brpoplpush
https://redis.io/docs/staging/DOC-5810/commands/brpoplpush
The only thing I'm not certain of is the badge coloring. Suggestions are welcome.